Clarify ambiguity in encryption spec/example #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From #43, as well as [packets.go](1), the final flag should be the first item in each payload packet in an encrypted message. However, the example currently places the final flag last in the payload packet, introducing ambiguity for those implementing the protocol. This commit changes the example to confirm to the actual implementation behaviour. 1: https://github.com/keybase/saltpack/blob/e19b1910c0c5e2e309b248ea32d1d05e6b868dc4/packets.go#L62
|
Not sure why CI is failing, this commit only changes files in |
|
Thanks for the correction! It took me a while to page all this back in, but I think the original confusion might've been that the final flag is the last field (of 2) in the signcryption mode, but the first field (of 3) here in the encryption-only mode. |
|
@malgorithms can you do a pull for this fix on the webserver? |
|
Thanks for the quick merge @oconnor663! Have a good one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #43, as well as packets.go, the final flag should be the first item in each payload packet in an encrypted message. However, the example currently places the final flag last in the payload packet, introducing ambiguity for those implementing the protocol. This commit changes the example to conform to the actual implementation behaviour.