Skip to content

Commit

Permalink
travis: Disable filter_secrets
Browse files Browse the repository at this point in the history
Disable `filter_secrets`, which hopefully makes our windows builds work. In
general, this wouldn't be a safe thing, because a malicious pull request could
leak our secrets. But we only run builds for master, not for pull requests or
any other branch, so what we do is well controlled, and shouldn't leak any.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
  • Loading branch information
algernon committed Feb 4, 2019
1 parent 3381a44 commit ead79b6
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .travis.yml
Expand Up @@ -5,6 +5,11 @@ os:
- linux
- osx
- windows
# This (filter_secrets) is generally unsafe, but we only run builds for master,
# so it is acceptable. If we remove the branch restriction, remove this too.
# If Windows builds on Travis are fixed, and work when secrets are in use,
# remove this too.
filter_secrets: false
matrix:
allow_failures:
- os: windows
Expand Down

0 comments on commit ead79b6

Please sign in to comment.