App.js: Fix onKeyboardConnect()'s navigate targets #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be navigating to `/layout-editor` or `/welcome`, not `./layout-editor` or `./welcome`. The distinction is important, the router doesn't know how to handle the latter ones. Fixing this navigation means we do not need the one in KeyboardSelect anymore. These two together restore the functionality of landing on the Welcome screen when Focus wasn't detected on the keyboard. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
0957758592
referenced
this pull request
in Dygmalab/Bazecor
Nov 18, 2019
App.js: Fix onKeyboardConnect()'s navigate targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be navigating to
/layout-editoror/welcome, not./layout-editoror./welcome. The distinction is important, the router doesn't know how to handle the latter ones.Fixing this navigation means we do not need the one in KeyboardSelect anymore.
These two together restore the functionality of landing on the Welcome screen when Focus wasn't detected on the keyboard.