Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Don't enable LED on Key_NoKey #5

Merged
merged 1 commit into from Mar 6, 2018
Merged

Conversation

tchernomax
Copy link
Contributor

Currently, when numpad layer is on, LED are enabled on XXX keys.
I think it's not what we want.

@algernon algernon self-assigned this Mar 5, 2018
@algernon
Copy link
Contributor

algernon commented Mar 5, 2018

At a first read, this looks good. There is maybe one corner case I'd test before merging it: if we have three layers active, the base one, a second one and NumPad, and the second one has XXXs, which the active LEDMode does highlight/animate, will this change stop that?

It probably doesn't, but the interactions between LEDModes and overriding plugins like this is complicated enough that I don't trust my first impressions. :)

@tchernomax
Copy link
Contributor Author

@algernon did you mean the following ?

enum { QWERTY, FUNCTION, NUMPAD };
…
const Key keymaps[][ROWS][COLS] PROGMEM = {
[QWERTY] = KEYMAP_STACKED( …, KEY_Q, …),
[FUNCTION] = KEYMAP_STACKED( …, XXX, …),
[NUMPAD] = KEYMAP_STACKED( …, ___, …)}
…

With this configuration, when I press numlock, Q isn't lighten up ; with or without the patch.

@algernon
Copy link
Contributor

algernon commented Mar 6, 2018

Yep, that's what I meant. Thanks for testing!

@algernon algernon self-requested a review March 6, 2018 07:40
@obra obra merged commit 28bd356 into keyboardio:master Mar 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants