Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveModColor: inactive until layer switch #507

Closed
algernon opened this issue Dec 20, 2018 · 0 comments
Closed

ActiveModColor: inactive until layer switch #507

algernon opened this issue Dec 20, 2018 · 0 comments
Labels
bug Something isn't working leds Issues related to LEDs plugin Issues related to otherwise unlisted plugins

Comments

@algernon
Copy link
Contributor

I seem to have broken ActiveModColor recently. When my keyboard boots up, the plugin does not highlight modifiers or layer keys until I switch to another layer, and press said keys there. Once done, it highlights them on the base layer too.
@algernon algernon added bug Something isn't working leds Issues related to LEDs plugin Issues related to otherwise unlisted plugins labels Dec 20, 2018
algernon added a commit that referenced this issue Dec 20, 2018
@algernon
LED-ActiveModColor: Use lookupOnActiveLayer() instead of lookup()
7528497 
When we use `lookup()`, we're looking up from the cache, not from the active
layer. If the cache gets updated later than we're called, we won't notice. So do
an explicit lookup.

Fixes #507.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
@algernon algernon mentioned this issue Dec 20, 2018
Merged
@obra obra closed this as completed in #508 Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working leds Issues related to LEDs plugin Issues related to otherwise unlisted plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@algernon