Implement KEY_INDEX and add getKeyswitchStateAtPosition to the HID facade #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cade To be used by the hardware implementations, `KEY_INDEX` tells us the index of a key, from which we can figure out the row and column as needed. The index starts at one, so that plugins that work with a list of key indexes can use zero as a sentinel. This is important, because when we initialize arrays with fewer elements than the declared array size, the remaining elements will be zero. We can use this to avoid having to explicitly add a sentinel in user-facing code. Additionally, we add `getKeyswitchStateAtPosition` to the HID facade. See its documentation in `Kaleidoscope-Hardware`. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
|
Why not use a constexpr function |
|
One issue with using a Mind you, moving |
To allow the hardware plugin to use a more efficient way of representing the index (if need be), and to be able to turn it into a constexpr, move it to the hardware plugin. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used by the hardware implementations,
KEY_INDEXtells us the index of a key, from which we can figure out the row and column as needed. The index starts at one, so that plugins that work with a list of key indexes can use zero as a sentinel. This is important, because when we initialize arrays with fewer elements than the declared array size, the remaining elements will be zero. We can use this to avoid having to explicitly add a sentinel in user-facing code.Additionally, we add
getKeyswitchStateAtPositionto the HID facade. See its documentation inKaleidoscope-Hardware.