Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the AppSwitcher and Kaleidoscope examples #341

Merged
merged 2 commits into from Jun 16, 2018
Merged

Fix the AppSwitcher and Kaleidoscope examples #341

merged 2 commits into from Jun 16, 2018

Conversation

algernon
Copy link
Contributor

  • The Kaleidoscope example was still using the Numlock plugin, move it to NumPad instead.
  • AppSwitcher relied on events being fired even in the idle case, which is not the case anymore. Move some of the logic to loop() to make the example functional again.

@algernon
examples/Kaleidoscope: Use NumPad instead of Numlock
830685d 
Since Numlock is deprecated, use NumPad instead, following what the factory
firmware did.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
@algernon
examples/AppSwitcher: Move the holding to loop()
ef6bc72 
For a while now, Kaleidoscope does nothing if keys are idle. This example relied
on events being fired in the idle case too. So instead of relying on that, move
the holding logic to `loop()`.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
@obra obra merged commit 88c1d3d into master Jun 16, 2018
@algernon algernon deleted the h/example-fixes branch June 16, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@algernon @obra