appswitcher example: add the line actually needed to make this work! #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algernon
approved these changes
Aug 16, 2018
| @@ -28,6 +28,7 @@ namespace H = kaleidoscope::hostos; | |||
| static bool appSwitchActive = false; | |||
|
|
|||
| const macro_t *macroAppSwitch(uint8_t keyState) { | |||
| appSwitchActive = true; | |||
There was a problem hiding this comment.
My first instinct was that this should be in the keyIsPressed() branch below, to not set it on key release. But in the end, that doesn't really matter, since cancel is done by a whole different key. I think this will be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
appSwitchActiveis nowhere set totrueso this example would not work at all!@algernon Please check.