Move most sources to a kaleidoscope/ subdir and namespace #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis tests will continue failing, because the |
Lots of things were already under the `kaleidoscope` namespace, but were in the "wrong" directory. This big patchset moves everything under `kaleidoscope/`, and namespaces `Layers_`. There are a few un-namespaced things, but because their use is so widespread, and they're used so commonly, we don't want to namespace those (like `handleKeyswitchEvent`), at least not yet. As a minor side-effect, this moves a few global statics that were once in `Layers.cpp` into the `Layer_` class itself, for clarity and encapsulation. Non-namespaced headers that were used outside of Kaleidoscope itself will still work, but will emit a compile-time warning. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
algernon
force-pushed
the
f/namespacing
branch
from
298aa69
to
3458f39
Compare
|
Turns out, I just needed to shadow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of things were already under the
kaleidoscopenamespace, but were in the "wrong" directory. This big patchset moves everything underkaleidoscope/, and namespacesLayers_. There are a few un-namespaced things, but because their use is so widespread, and they're used so commonly, we don't want to namespace those (likehandleKeyswitchEvent), at least not yet.As a minor side-effect, this moves a few global statics that were once in
Layers.cppinto theLayer_class itself, for clarity and encapsulation.Non-namespaced headers that were used outside of Kaleidoscope itself will still work, but will emit a compile-time warning.
This is a prerequirement for #137. The hardware plugins use
macro_helpers.h, andQukeysuseskey_defs_keymaps.h, which are deprecated by this PR, and will emit warnings. I will be submitting separate PRs to clean those up.