Remove now-obsolete idle checks from a few plugins #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A long-long time ago, Kaleidoscope used to call `onKeyswitchEvent` (or rather, it's then-current incarnation) even when keys were idle. For a number of plugins, this was a case they didn't want to handle, and bailed out early. When we changed Kaleidoscope to not call the event handlers for idle keys, these plugins weren't modified at the same time, and the superfluous check remained, making the firmware both larger and marginally slower. Since the event handlers are never called when idle, it is safe to remove these checks. Affected plugins are `Leader`, `OneShot`, and `TapDance`. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
|
This shaves 100(!) bytes off of my own sketch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long-long time ago, Kaleidoscope used to call
onKeyswitchEvent(or rather, it's then-current incarnation) even when keys were idle. For a number of plugins, this was a case they didn't want to handle, and bailed out early.When we changed Kaleidoscope to not call the event handlers for idle keys, these plugins weren't modified at the same time, and the superfluous check remained, making the firmware both larger and marginally slower.
Since the event handlers are never called when idle, it is safe to remove these checks.
Affected plugins are
Leader,OneShot, andTapDance.