Optimize keyscanner for 'avr' native keyboards #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
This reverts commit 91b7c0c. Signed-off-by: Jesse Vincent <jesse@keyboard.io>
what we 'really' want per switch manufacturers Signed-off-by: Jesse Vincent <jesse@keyboard.io>
not just when the timer triggers Signed-off-by: Jesse Vincent <jesse@keyboard.io>
reading. (This eliminates a "chatter" causing bug Signed-off-by: Jesse Vincent <jesse@keyboard.io>
obra
force-pushed
the
f/optimize-avr-keyboards
branch
from
e955af2
to
d193d7b
Compare
Otherwise, for example, Pin F0 may not be read on the Planck Signed-off-by: Jesse Vincent <jesse@keyboard.io>
Based on the change made to `ATMegaKeyboard`, apply the same treatment to the `ErgoDoxScanner` too, and run debouncing only 3 times per 5ms, which is closer to what switch manufacturers recommend. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
Set the previous key state when reporting the state to Kaleidoscope, instead of on every read. This eliminates a possible chatter bug. Idea taken from a similar change made to `ATMegaKeyboard`. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
Instead of only reporting the state when the timer triggers, report it every loop, even if it is unchanged. This is based on a similar change to `ATMegaKeyboard`. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
Based on a similar change to `ATMegaKeyboard`. Signed-off-by: Gergely Nagy <algernon@keyboard.io>
|
Loving it. Code size is bigger (by about 800 bytes), but cycle times went from 0.64ms to 0.16ms. That alone is worth the extra size in my book, especially when paired with a serious bug fixed. I pushed a few ErgoDox changes that apply similar fixes & optimizations there. The speedup in that case isn't that big (yet): from 2.2ms to 1.6ms using my own sketch, at the cost of ~800 bytes of PROGMEM. There's room to improve in the ErgoDox case, I think, but this is already nice enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@algernon - Please have a look at this branch. I believe it's significantly faster than your handrolled atreus keyscanner. (And fixes a serious bug that was masked by having a really slow scanner ;)