Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horreum: Include latencies from Infinispan Metrics #636

Closed
andyuk1986 opened this issue Dec 13, 2023 · 3 comments · Fixed by #794
Closed

Horreum: Include latencies from Infinispan Metrics #636

andyuk1986 opened this issue Dec 13, 2023 · 3 comments · Fixed by #794
Assignees
@andyuk1986

Comments

@andyuk1986
Copy link
Contributor

  • Implement logic for retrieving the latencies information from Infinispan metrics.
  • Update the schema in Horreum correspondingly.
@andyuk1986 andyuk1986 self-assigned this Dec 13, 2023
andyuk1986 pushed a commit to andyuk1986/keycloak-benchmark that referenced this issue Mar 27, 2024
Horreum: Include latencies from Infinispan Metrics keycloak#636
163207a
andyuk1986 pushed a commit to andyuk1986/keycloak-benchmark that referenced this issue Mar 27, 2024
Horreum: Include latencies from Infinispan Metrics keycloak#636
19adbd1 
Signed-off-by: Anna Manukyan <amanukya@redhat.com>
@andyuk1986
Copy link
Contributor Author

PR with ISPN metrics inclusion is sent #749 .
Separate PR will be sent with changes for resetting ISPN statistics over JMX.

@ahus1 ahus1 mentioned this issue Apr 2, 2024
Merged
ahus1 pushed a commit that referenced this issue Apr 2, 2024
@andyuk1986
Horreum: Include latencies from Infinispan Metrics #636 (#749)
9f04a2f 
Signed-off-by: Anna Manukyan <amanukya@redhat.com>
@ahus1
Copy link
Contributor

ahus1 commented Apr 29, 2024

@andyuk1986 - I gave it another thought about the metric that currently needs a reset via JMX. I was hoping that there would be an existing CLI to reset the metric, and even for that I was on the fence.

To have another application to reset a metric seems to be a bit much, and I wonder if people monitoring Infinispan would suffer from similar problems. If this is the case, we should rather change the collection of metrics, than having a workaround of a separate application to reset the metric.

Could you please set up a meeting with you, me and the team so we could take a step back to evaluate options?

andyuk1986 pushed a commit to andyuk1986/keycloak-benchmark that referenced this issue May 2, 2024
Updated ISPN Metrics calculation. keycloak#636
2664a90 
Signed-off-by: Anna Manukyan <amanukya@redhat.com>
@andyuk1986
Copy link
Contributor Author

I have updated the ispn metric implementation according to our's Monday discussion. Sent a PR #794

@ahus1 ahus1 mentioned this issue May 2, 2024
Merged
ahus1 pushed a commit that referenced this issue May 2, 2024
@andyuk1986
Updated ISPN Metrics calculation to include xsite latency per run
547f745 
Closes #636

Signed-off-by: Anna Manukyan <amanukya@redhat.com>
Co-authored-by: Anna Manukyan <amanukya@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyuk1986 andyuk1986

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated ISPN Metrics calculation. andyuk1986/keycloak-benchmark
2 participants
@andyuk1986 @ahus1