Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Route53 scripts for OCP 4.14.5 #650

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

ryanemerson
Copy link
Contributor

No description provided.

A Network Load Balancer is now provisioned, instead of a Classic Load
Balancer, so the scripts have been updated to make use of the 'aws
elbv2' api.

Signed-off-by: Ryan Emerson <remerson@redhat.com>
Copy link
Contributor

@kami619 kami619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kami619 kami619 merged commit 34e1d41 into keycloak:main Dec 19, 2023
1 check passed
@ahus1
Copy link
Contributor

ahus1 commented Dec 20, 2023

@ryanemerson - I assume the changes done here would need to be reflected in our blueprint here: https://www.keycloak.org/high-availability/deploy-aws-route53-loadbalancer

Please create two follow-up issue in Keycloak's main repository for this and link them from here:

(a) an issue to update to list which ROSA version this original recipe was tested with in the prerequisites. This would then be backported to KC22 "timely"
(b) a follow-up issue which updates the blueprint for OCP 4.14.x to use elbv2

If we think we are fast enough with (b) to be ready and backported to KC22, we can do only (b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants