Clean dangling DHCP Options #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Hajas <mhajas@redhat.com>
|
would this become moot once we switch to AWS CDK ? @mhajas |
|
Not sure what you mean @kami619. Like I should write this code using AWS CDK? Or that we won't need this when we use AWS CDK? |
|
I mean, we might not have to handle the iterative deletes once we implement delete objects with AWS CDK. But we could still use this for the time being. |
|
IMHO DHCP Options are dangling resources from a ROSA cluster creation, which we might not (never?) create via CDK. So IMHO this is valid to keep as a CLI automated cleanup. |
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
mhajas
commented
Mar 14, 2024
doc/kubernetes/modules/ROOT/pages/openshift/cross-site-rosa.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the following issue https://issues.redhat.com/browse/OCPBUGS-1838. We can watch the script output and maybe provide a reproducer for the issue if we find it.
We have around 30 DHCP options still present in our account. I left it present if anyone would like to test the script.