-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dataset options for setting password hashing algorithm and iterations. #778
Conversation
…o the dataset provider module. Signed-off-by: Tomas Kyjovsky <tkyjovsk@redhat.com>
1a2f6f2
to
64349a8
Compare
@tkyjovsk thanks a lot for adding this back in a proper way. I think we have to update the docs. Ref., from last time when we modified them - https://github.com/keycloak/keycloak-benchmark/pull/751/files#diff-cdf53b413cfe9e2a53e09baeed0645f6744d883049fb1f458d6d8e4155921496L34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to update the docs.
@tkyjovsk I am going to add the docs and test it. |
Tested with different hashing algorithm values and iterations that are set for KC22, KC24, KC25 and users are created as expected in the specific realms.
|
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
…ations. (keycloak#778) * Added options for setting password hashing algorithm and iterations to the dataset provider module. Signed-off-by: Tomas Kyjovsky <tkyjovsk@redhat.com> * updating docs Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com> --------- Signed-off-by: Tomas Kyjovsky <tkyjovsk@redhat.com> Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com> Co-authored-by: Kamesh Akella <kamesh.asp@gmail.com> # Conflicts: # dataset/dataset-import.sh # dataset/src/main/java/org/keycloak/benchmark/dataset/DatasetResourceProvider.java # dataset/src/main/java/org/keycloak/benchmark/dataset/config/DatasetConfig.java # doc/dataset/modules/ROOT/pages/using-provider.adoc
…ations. (#778) (#780) * Added options for setting password hashing algorithm and iterations to the dataset provider module. Signed-off-by: Tomas Kyjovsky <tkyjovsk@redhat.com> * updating docs Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com> --------- Signed-off-by: Tomas Kyjovsky <tkyjovsk@redhat.com> Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com> Co-authored-by: Kamesh Akella <kamesh.asp@gmail.com> # Conflicts: # dataset/dataset-import.sh # dataset/src/main/java/org/keycloak/benchmark/dataset/DatasetResourceProvider.java # dataset/src/main/java/org/keycloak/benchmark/dataset/config/DatasetConfig.java # doc/dataset/modules/ROOT/pages/using-provider.adoc
Added options
-g ALGORITHM
and-i ITERATIONS
to thedataset-import.sh
script for adjusting the realm password policy. Both are optional. TheDatasetResourceProvider
will only apply the options which were provided.