This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
KEYCLOAK-5811 Client Authentication by JWS Client Assertion in client secret #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed (commit fce2c1d) Full Log |
mposolda
approved these changes
Jan 24, 2018
|
@tnorimat Looks good to me. Thanks! I've added also @matthewhelmke (our docs expert) if he has some additional feedback. The travis build failed, but it seems it's not your fault. I saw this in some other PR too... Will try to take a look. |
|
@matthewhelmke FYI. The Travis failure doesn't seem to be caused by this PR, but by the KEYCLOAK-6353 . I've sent another PR to fix that: #298 . After fixing that, the travis re-run should hopefully pass. |
matthewhelmke
approved these changes
Jan 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for keycloak/keycloak#4835