Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip broken tests #427

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Skip broken tests #427

merged 1 commit into from
Sep 26, 2022

Conversation

jonkoops
Copy link
Contributor

No description provided.

@jonkoops jonkoops self-assigned this Sep 20, 2022
edewit
edewit requested changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@edewit edewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still fails

@jonkoops
Copy link
Contributor Author

@edewit Yeah, need the changes in #422 as well.

@jonkoops jonkoops marked this pull request as ready for review September 20, 2022 14:20
@jonkoops jonkoops mentioned this pull request Sep 20, 2022
Open
@jonkoops
Copy link
Contributor Author

Created #428 to re-enable the tests that are being skipped in this PR.

@jonkoops jonkoops merged commit d787a45 into main Sep 26, 2022
@jonkoops jonkoops deleted the skip-broken-tests branch September 26, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edewit edewit edewit approved these changes

@abstractj abstractj Awaiting requested review from abstractj

@ssilvert ssilvert Awaiting requested review from ssilvert

Assignees

@jonkoops jonkoops

Labels
kind/bug priority/critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonkoops @edewit