Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

KEYCLOAK-14066 Add Realm CRD tests #179

Merged
merged 2 commits into from
May 12, 2020

Conversation

mhajas
Copy link
Contributor

@mhajas mhajas commented May 4, 2020

JIRA ID

Additional Information

Verification Steps

Checklist:

  • Verified by team member
  • Comments where necessary
  • Automated Tests
  • Documentation changes if necessary

Additional Notes

@mhajas mhajas force-pushed the KEYCLOAK-13632-Extend-testing branch from 4b34872 to 3e262f0 Compare May 4, 2020 14:59
Copy link
Contributor

@slaskawi slaskawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 2 small comments. Once they are addressed and Travis is happy - it will look good to me.

test/e2e/keycloak_realm_test.go Outdated Show resolved Hide resolved
test/e2e/keycloak_realm_test.go Outdated Show resolved Hide resolved
@mhajas mhajas changed the title KEYCLOAK-13632 Add Realm CRD tests KEYCLOAK-14066 Add Realm CRD tests May 5, 2020
@mhajas mhajas force-pushed the KEYCLOAK-13632-Extend-testing branch from 3e262f0 to 9d86046 Compare May 6, 2020 11:08
@abstractj abstractj closed this May 6, 2020
@abstractj abstractj reopened this May 6, 2020
@mhajas mhajas force-pushed the KEYCLOAK-13632-Extend-testing branch from 9d86046 to 2e391f2 Compare May 6, 2020 11:47
@slaskawi
Copy link
Contributor

slaskawi commented May 8, 2020

@mhajas Travis is still very... very sad 😭

@mhajas mhajas closed this May 11, 2020
@mhajas mhajas reopened this May 11, 2020
@mhajas mhajas force-pushed the KEYCLOAK-13632-Extend-testing branch 2 times, most recently from 35b3ba3 to a99daa0 Compare May 12, 2020 09:53
@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage increased (+1.5%) to 42.168% when pulling cf1675e on mhajas:KEYCLOAK-13632-Extend-testing into 3ed671b on keycloak:master.

@mhajas mhajas force-pushed the KEYCLOAK-13632-Extend-testing branch from a99daa0 to 14bb62d Compare May 12, 2020 10:12
@mhajas mhajas force-pushed the KEYCLOAK-13632-Extend-testing branch from 14bb62d to cf1675e Compare May 12, 2020 10:34
@slaskawi slaskawi merged commit 3b14a25 into keycloak:master May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants