This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
KEYCLOAK-14316 Fix "assignment to entry in nil map" error #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlunde
reviewed
Jul 16, 2020
slaskawi
force-pushed
the
KEYCLOAK-14316-Fix-nil-map-assignment-error
branch
from
3489d55
to
d5b4fda
Compare
ASzc
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Seems from here the built in casting for golang will correctly handle unicode in both directions, so that's ok. It cautions against trying to perform operations on the byte[], as your code would break with unicode multi-byte characters. I don't see any problems like that in this PR.
|
@abstractj May I ask you to review and merge this one (already approved by @ASzc). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ID
https://issues.redhat.com/browse/KEYCLOAK-14316
Additional Information
Checklist: