INTLY-8357 Pod monitor removal

[obrienrobert]

JIRA ID

https://issues.redhat.com/browse/INTLY-8357

Additional Information

This PR removes the PodMonitor resource which was added as part of the following PR: #114.

Verification Steps

• Checkout this branch
• Apply all the CRDs etc: make cluster/prepare
• Deploy the operator locally: operator-sdk run --local --namespace "keycloak"
• Apply the Keycloak CR: oc apply -f deploy/examples/keycloak/keycloak.yaml
• Apply the Keycloak Realm CR: oc apply -f deploy/examples/realm/basic_realm.yaml
• Verify that no PodMonitor has been created and that the operator logs contain no reference to a PodMonitor resource:

{"level":"info","ts":1597657288.0097225,"logger":"controller_keycloak","msg":"Reconciling Keycloak","Request.Namespace":"keycloak","Request.Name":"example-keycloak"}
{"level":"info","ts":1597657288.0260136,"logger":"action_runner","msg":"(    0)    SUCCESS Update Keycloak admin secret"}
{"level":"info","ts":1597657288.0463824,"logger":"action_runner","msg":"(    1)    SUCCESS update keycloak prometheus rule"}
{"level":"info","ts":1597657288.0647643,"logger":"action_runner","msg":"(    2)    SUCCESS update keycloak service monitor"}
{"level":"info","ts":1597657288.1027825,"logger":"action_runner","msg":"(    3)    SUCCESS update keycloak grafana dashboard"}
{"level":"info","ts":1597657288.1177003,"logger":"action_runner","msg":"(    4)    SUCCESS Update Database Secret"}
{"level":"info","ts":1597657288.1337612,"logger":"action_runner","msg":"(    5)    SUCCESS Update Postgresql PersistentVolumeClaim"}
{"level":"info","ts":1597657288.1505246,"logger":"action_runner","msg":"(    6)    SUCCESS Update Postgresql Deployment"}
{"level":"info","ts":1597657288.166885,"logger":"action_runner","msg":"(    7)    SUCCESS Update Postgresql KeycloakService"}
{"level":"info","ts":1597657288.18427,"logger":"action_runner","msg":"(    8)    SUCCESS Update keycloak Service"}
{"level":"info","ts":1597657288.2011492,"logger":"action_runner","msg":"(    9)    SUCCESS Update keycloak Discovery Service"}
{"level":"info","ts":1597657288.219888,"logger":"action_runner","msg":"(   10)    SUCCESS Update Keycloak Deployment (StatefulSet)"}
{"level":"info","ts":1597657288.238407,"logger":"action_runner","msg":"(   11)    SUCCESS Update Keycloak Route"}
{"level":"info","ts":1597657288.254205,"logger":"action_runner","msg":"(   12)    SUCCESS Update PodDisruptionBudget"}

Checklist:

• Automated Tests
• Documentation changes if necessary
• (If required) Discussed on Keycloak DEV

[obrienrobert]

@slaskawi @abstractj would it be possible to get feedback on this whenever you get a chance, please?

[slaskawi]

@obrienrobert The code itself looks fine. However, we need additional changes in:

• https://github.com/keycloak/keycloak-operator/blob/master/deploy/role.yaml
• https://github.com/keycloak/keycloak-operator/blob/master/deploy/cluster_roles/cluster_role.yaml

[slaskawi]

Integrated, thanks @obrienrobert

[obrienrobert]

Great! Thanks for the review/feedback @slaskawi