KEYCLOAK-14782 KEYCLOAK-14470 KEYCLOAK-12677 Custom Configuration #255
Conversation
slaskawi
force-pushed
the
KEYCLOAK-14782-Custom-Configuration
branch
from
52b3c46
to
21ec4cd
Compare
slaskawi
force-pushed
the
KEYCLOAK-14782-Custom-Configuration
branch
from
21ec4cd
to
c468da2
Compare
slaskawi
force-pushed
the
KEYCLOAK-14782-Custom-Configuration
branch
from
c468da2
to
c062b3d
Compare
slaskawi
changed the title
slaskawi
force-pushed
the
KEYCLOAK-14782-Custom-Configuration
branch
from
c062b3d
to
f186a62
Compare
slaskawi
force-pushed
the
KEYCLOAK-14782-Custom-Configuration
branch
from
f186a62
to
f775bf1
Compare
| "github.com/keycloak/keycloak-operator/pkg/apis/keycloak/v1alpha1.KeycloakStatus": schema_pkg_apis_keycloak_v1alpha1_KeycloakStatus(ref), | ||
| "github.com/keycloak/keycloak-operator/pkg/apis/keycloak/v1alpha1.KeycloakUser": schema_pkg_apis_keycloak_v1alpha1_KeycloakUser(ref), | ||
| "github.com/keycloak/keycloak-operator/pkg/apis/keycloak/v1alpha1.KeycloakUserSpec": schema_pkg_apis_keycloak_v1alpha1_KeycloakUserSpec(ref), | ||
| "github.com/keycloak/keycloak-operator/pkg/apis/keycloak/v1alpha1.KeycloakUserStatus": schema_pkg_apis_keycloak_v1alpha1_KeycloakUserStatus(ref), |
There was a problem hiding this comment.
Are all these references to the github repo going to be a problem for product?
There was a problem hiding this comment.
Good point but I wonder what's the purpose of this file anyway. It looks generated...? In any case, if I understand it correctly, it used relative paths before (i.e. local paths) but now it refers to github. This might cause some inconsistencies.
There was a problem hiding this comment.
The OpenAPI parts are responsible for CRD validation (see the documentation). In other words - it enables kubebuilder annotations (such as // +listType=set or // +optional).
And yes, this file is generated automatically (by our target make code/gen). I'm not sure why it requires full file names. At some point I know it used relative paths, which was a bit more intuitive.
This way or another - this is not a problem for productization (we have similar parts there as well).
JIRA ID
https://issues.redhat.com/browse/KEYCLOAK-14782
https://issues.redhat.com/browse/KEYCLOAK-14470
https://issues.redhat.com/browse/KEYCLOAK-12677
Additional Information
See the design document: https://groups.google.com/g/keycloak-dev/c/aCVDs6uxYk4
Checklist:
This Pull Request doesn't require any documentation update nor e2e test. It is an experimental feature, which should be used only when there's no other choice. Whenever you need to use it - please consult it with the Keycloak Team. Perhaps we to enhance features provided out of the box for this Operator.