This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
Intly 3225 #39
Merged
Intly 3225 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Oct 1, 2019
davidffrench
reviewed
Oct 1, 2019
There was a problem hiding this comment.
@pb82 The changes are fantastic. I love the refactor of the autodetect, much better.
I have run it locally, I am not sure why but the reconcile loop is executing multiple times a second. I am not sure what is causing this. Would you be able to check if this is happening for you.
I am also not able to log into Keycloak with the admin username and password.
slaskawi
suggested changes
Oct 2, 2019
There was a problem hiding this comment.
There are two major things that needs some thought:
- There's a clash between this PR and fix: Refactor admin secret #38
- There are lots of lint errors that probably it's worth to address
golangcibot
reviewed
Oct 2, 2019
slaskawi
suggested changes
Oct 2, 2019
golangcibot
reviewed
Oct 2, 2019
slaskawi
previously approved these changes
Oct 4, 2019
| @@ -130,6 +130,8 @@ github.com/mitchellh/go-homedir | |||
| github.com/modern-go/concurrent | |||
| # github.com/modern-go/reflect2 v1.0.1 | |||
| github.com/modern-go/reflect2 | |||
| # github.com/openshift/api v3.9.0+incompatible | |||
There was a problem hiding this comment.
Is this intentional? If so, can we just remove it?
There was a problem hiding this comment.
This is needed because it contains the Route type
slaskawi
approved these changes
Oct 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ID
INTLY-3225
Additional Information
Creates an Ingress or Route if
spec.externalAccess.enabledis set to True in the keycloak CR. A Route is only created on OpenShift. Also some refactoring.Verification Steps