Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing attributes to support step up authentication #18355

Closed
ssilvert opened this issue Mar 3, 2022 · 7 comments · Fixed by keycloak/keycloak-ui#2411
Closed

Missing attributes to support step up authentication #18355

ssilvert opened this issue Mar 3, 2022 · 7 comments · Fixed by keycloak/keycloak-ui#2411
Assignees
Labels
impact/high kind/bug Categorizes a PR related to a bug team/ui

Comments

@ssilvert
Copy link
Contributor

ssilvert commented Mar 3, 2022

Describe the bug

We need to add attributes to support step-up authentication. These have already been added in the latest version of the old Admin UI.

Here is snippet of email from @mposolda :

  1. Step-up authentication: There are already some configuration
    properties in the keycloak "main" branch. I've tagged you in some PRs
    before, but not sure if you saw this and PRs are merged already. The
    changes are:

Those properties are already available in the keycloak main branch, but
there will be feature check added (properties will be available just
when explicitly enabled by feature "step-up-authentication").

Version

18.0.0-SNAPSHOT

Screen Design

Marvel

@ssilvert ssilvert added kind/bug Categorizes a PR related to a bug impact/high labels Mar 3, 2022
@xianli123
Copy link
Contributor

Hi @ssilvert I found that this issue mentioned a new feature regarding Authentication. Should I provide a design for this feature? And what is your plan for this feature?

@ssilvert
Copy link
Contributor Author

@xianli123 I believe this just comes down to the addition of a few fields, so we don't need an all new design. But it might be nice if the existing design is updated.

@xianli123
Copy link
Contributor

@ssilvert Ok, I can update the design of this new feature. I've tried to initiate the Keycloak 18.0 release but failed. So I can't see this feature in my current console. Do you have relevant requirements and screen shots of it? Or wait until version 18 is released to implement this feature? Thanks.

@ssilvert
Copy link
Contributor Author

@xianli123 I think we need to get you a snapshot version of Keycloak 18. As we are in the transition from old UI to new UI, we will need to keep up with changes.

As far as I know, we don't have a nightly build for you to download. Can you try to build it yourself?
https://github.com/keycloak/keycloak/blob/main/docs/building.md

@xianli123
Copy link
Contributor

Ok. I've tried to build the 18.0 version based on this doc but failed. I will try it again. Thanks.

@ssilvert
Copy link
Contributor Author

@xianli123 If you are still having trouble we can schedule a video chat and I will walk you through it. I do think you will need to be able to build it yourself as long as new changes are still allowed in the old UI.

@xianli123
Copy link
Contributor

Ok, thanks. I've already seen Haley's demo. I will try it by myself. And I think I can provide some designs.

@edewit edewit self-assigned this Apr 7, 2022
edewit referenced this issue in edewit/keycloak-admin-ui Apr 8, 2022
jonkoops referenced this issue in edewit/keycloak-admin-ui Apr 11, 2022
edewit referenced this issue in edewit/keycloak-admin-ui Apr 11, 2022
jonkoops referenced this issue in edewit/keycloak-admin-ui Apr 19, 2022
edewit referenced this issue in edewit/keycloak-admin-ui Apr 20, 2022
@ssilvert ssilvert transferred this issue from keycloak/keycloak-ui Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/high kind/bug Categorizes a PR related to a bug team/ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants