Skip to content

Commit

Permalink
KEYCLOAK-8940 Stabilize SessionsPreloadCrossDCTest.loginFailuresPrelo…
Browse files Browse the repository at this point in the history 
…adTest
  • Loading branch information
@hmlnarik
hmlnarik committed Dec 4, 2018
1 parent bba081d commit 00e0ba8
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 27 deletions.
9 changes: 4 additions & 5 deletions ...suite-providers/src/main/java/org/keycloak/testsuite/rest/resource/TestCacheResource.java
View file
Expand Up @@ -42,6 +42,7 @@
import org.keycloak.models.sessions.infinispan.util.InfinispanUtil; import org.keycloak.models.sessions.infinispan.util.InfinispanUtil;
import org.keycloak.testsuite.rest.representation.JGroupsStats; import org.keycloak.testsuite.rest.representation.JGroupsStats;
import org.keycloak.utils.MediaType; import org.keycloak.utils.MediaType;
import org.infinispan.stream.CacheCollectors;


/** /**
* @author <a href="mailto:mposolda@redhat.com">Marek Posolda</a> * @author <a href="mailto:mposolda@redhat.com">Marek Posolda</a>
Expand Down Expand Up @@ -76,11 +77,9 @@ public boolean containsUuid(@PathParam("id") String id) {
@Path("/enumerate-keys") @Path("/enumerate-keys")
@Produces(MediaType.APPLICATION_JSON) @Produces(MediaType.APPLICATION_JSON)
public Set<String> enumerateKeys() { public Set<String> enumerateKeys() {
return cache.keySet().stream().map((Object o) -> { return cache.keySet().stream()

.map(Object::toString)
return o.toString(); .collect(CacheCollectors.serializableCollector(Collectors::toSet)); // See https://issues.jboss.org/browse/ISPN-7596

}).collect(Collectors.toSet());
} }




Expand Down
2 changes: 1 addition & 1 deletion ...quillian/tests/base/src/test/java/org/keycloak/testsuite/crossdc/AbstractCrossDCTest.java
View file
Expand Up @@ -74,7 +74,7 @@ public void afterAbstractKeycloakTest() {
} }


private void enableOnlyFirstNodeInFirstDc() { private void enableOnlyFirstNodeInFirstDc() {
log.debug("--DC: Enable only first node in first datacenter"); log.debug("--DC: Enable only first node in first datacenter @ load balancer");
this.loadBalancerCtrl.disableAllBackendNodes(); this.loadBalancerCtrl.disableAllBackendNodes();
if (!CrossDCTestEnricher.getBackendNode(DC.FIRST, 0).isStarted()) { if (!CrossDCTestEnricher.getBackendNode(DC.FIRST, 0).isStarted()) {
throw new IllegalStateException("--DC: Trying to enable not started node on load-balancer"); throw new IllegalStateException("--DC: Trying to enable not started node on load-balancer");
Expand Down
38 changes: 17 additions & 21 deletions ...n/tests/base/src/test/java/org/keycloak/testsuite/crossdc/SessionsPreloadCrossDCTest.java
View file
Expand Up @@ -31,6 +31,8 @@
import org.keycloak.testsuite.arquillian.CrossDCTestEnricher; import org.keycloak.testsuite.arquillian.CrossDCTestEnricher;
import org.keycloak.testsuite.arquillian.annotation.InitialDcState; import org.keycloak.testsuite.arquillian.annotation.InitialDcState;
import org.keycloak.testsuite.util.OAuthClient; import org.keycloak.testsuite.util.OAuthClient;
import java.util.Set;
import org.hamcrest.Matchers;


/** /**
* Tests userSessions and offline sessions preloading at startup * Tests userSessions and offline sessions preloading at startup
Expand Down Expand Up @@ -72,11 +74,10 @@ public void sessionsPreloadTest() throws Exception {
enableLoadBalancerNode(DC.SECOND, 0); enableLoadBalancerNode(DC.SECOND, 0);


// Ensure sessions are loaded in both 1st DC and 2nd DC // Ensure sessions are loaded in both 1st DC and 2nd DC
int sessions01 = getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.USER_SESSION_CACHE_NAME).size(); Set<String> sessions01keys = getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.USER_SESSION_CACHE_NAME).enumerateKeys();
int sessions02 = getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.USER_SESSION_CACHE_NAME).size(); Set<String> sessions02keys = getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.USER_SESSION_CACHE_NAME).enumerateKeys();
log.infof("sessions01: %d, sessions02: %d", sessions01, sessions02); log.infof("sessions01keys: %s, sessions02keys: %s", sessions01keys, sessions02keys);
Assert.assertEquals(sessions01, sessionsBefore + SESSIONS_COUNT); Assert.assertThat(sessions01keys, Matchers.equalTo(sessions02keys));
Assert.assertEquals(sessions02, sessionsBefore + SESSIONS_COUNT);


// On DC2 sessions were preloaded from remoteCache // On DC2 sessions were preloaded from remoteCache
Assert.assertTrue(getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.WORK_CACHE_NAME).contains("distributed::remoteCacheLoad::sessions")); Assert.assertTrue(getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.WORK_CACHE_NAME).contains("distributed::remoteCacheLoad::sessions"));
Expand Down Expand Up @@ -117,11 +118,10 @@ public void offlineSessionsPreloadTest() throws Exception {
enableLoadBalancerNode(DC.SECOND, 0); enableLoadBalancerNode(DC.SECOND, 0);


// Ensure sessions are loaded in both 1st DC and 2nd DC // Ensure sessions are loaded in both 1st DC and 2nd DC
int offlineSessions11 = getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.OFFLINE_USER_SESSION_CACHE_NAME).size(); Set<String> offlineSessions11keys = getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.OFFLINE_USER_SESSION_CACHE_NAME).enumerateKeys();
int offlineSessions12 = getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.OFFLINE_USER_SESSION_CACHE_NAME).size(); Set<String> offlineSessions12keys = getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.OFFLINE_USER_SESSION_CACHE_NAME).enumerateKeys();
log.infof("offlineSessions11: %d, offlineSessions12: %d", offlineSessions11, offlineSessions12); log.infof("offlineSessions11keys: %s, offlineSessions12keys: %s", offlineSessions11keys, offlineSessions12keys);
Assert.assertEquals(offlineSessions11, offlineSessionsBefore + SESSIONS_COUNT); Assert.assertThat(offlineSessions11keys, Matchers.equalTo(offlineSessions12keys));
Assert.assertEquals(offlineSessions12, offlineSessionsBefore + SESSIONS_COUNT);


// On DC1 sessions were preloaded from DB. On DC2 sessions were preloaded from remoteCache // On DC1 sessions were preloaded from DB. On DC2 sessions were preloaded from remoteCache
Assert.assertTrue(getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.WORK_CACHE_NAME).contains("distributed::offlineUserSessions")); Assert.assertTrue(getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.WORK_CACHE_NAME).contains("distributed::offlineUserSessions"));
Expand Down Expand Up @@ -164,18 +164,17 @@ public void loginFailuresPreloadTest() throws Exception {


Retry.execute(() -> { Retry.execute(() -> {
// Ensure loginFailures are loaded in both 1st DC and 2nd DC // Ensure loginFailures are loaded in both 1st DC and 2nd DC
int size1 = getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.LOGIN_FAILURE_CACHE_NAME).size(); Set<String> keys1 = getTestingClientForStartedNodeInDc(0).testing().cache(InfinispanConnectionProvider.LOGIN_FAILURE_CACHE_NAME).enumerateKeys();
int size2 = getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.LOGIN_FAILURE_CACHE_NAME).size(); Set<String> keys2 = getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.LOGIN_FAILURE_CACHE_NAME).enumerateKeys();
int loginFailures1 = (Integer) getAdminClientForStartedNodeInDc(0).realm("test").attackDetection().bruteForceUserStatus(userId).get("numFailures"); int loginFailures1 = (Integer) getAdminClientForStartedNodeInDc(0).realm("test").attackDetection().bruteForceUserStatus(userId).get("numFailures");
int loginFailures2 = (Integer) getAdminClientForStartedNodeInDc(1).realm("test").attackDetection().bruteForceUserStatus(userId).get("numFailures"); int loginFailures2 = (Integer) getAdminClientForStartedNodeInDc(1).realm("test").attackDetection().bruteForceUserStatus(userId).get("numFailures");
log.infof("size1: %d, size2: %d, loginFailures1: %d, loginFailures2: %d", size1, size2, loginFailures1, loginFailures2); log.infof("keys1: %d, keys2: %d, loginFailures1: %d, loginFailures2: %d", keys1, keys2, loginFailures1, loginFailures2);
Assert.assertEquals(size1, 1); Assert.assertThat(keys1, Matchers.equalTo(keys2));
Assert.assertEquals(size2, 1); Assert.assertEquals(loginFailuresBefore + SESSIONS_COUNT, loginFailures1);
Assert.assertEquals(loginFailures1, loginFailuresBefore + SESSIONS_COUNT); Assert.assertEquals(loginFailuresBefore + SESSIONS_COUNT, loginFailures2);
Assert.assertEquals(loginFailures2, loginFailuresBefore + SESSIONS_COUNT);
}, 3, 400); }, 3, 400);


// On DC2 sessions were preloaded from from remoteCache // On DC2 sessions were preloaded from remoteCache
Assert.assertTrue(getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.WORK_CACHE_NAME).contains("distributed::remoteCacheLoad::loginFailures")); Assert.assertTrue(getTestingClientForStartedNodeInDc(1).testing().cache(InfinispanConnectionProvider.WORK_CACHE_NAME).contains("distributed::remoteCacheLoad::loginFailures"));


// Disable brute force protector // Disable brute force protector
Expand All @@ -202,7 +201,4 @@ private List<OAuthClient.AccessTokenResponse> createInitialSessions(boolean offl


return responses; return responses;
} }



} }

0 comments on commit 00e0ba8

Please sign in to comment.