Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old HotRod index annotation with new one #12493

Closed
mhajas opened this issue Jun 14, 2022 · 5 comments · Fixed by #15676
Closed

Replace old HotRod index annotation with new one #12493

mhajas opened this issue Jun 14, 2022 · 5 comments · Fixed by #15676
Assignees
Labels
area/storage Indicates an issue that touches storage (change in data layout or data manipulation)
Milestone

Comments

@mhajas
Copy link
Contributor

mhajas commented Jun 14, 2022

Infinispan introduced new annotations in https://issues.redhat.com/browse/ISPN-13842, we should use these instead of the old one

@mhajas mhajas added area/storage Indicates an issue that touches storage (change in data layout or data manipulation) team/storage-sig labels Jun 14, 2022
@martin-kanis
Copy link
Contributor

With this issue we probably should update <infinispan.protostream.processor.version> property to 4.5.0.Final to be aligned with Quarkus/Infinispan 14. This wasn't done in #14925 because it was failing on compilation error in a generators. Probably due to old index annotations.

@mhajas
Copy link
Contributor Author

mhajas commented Nov 3, 2022

This is weird. I believe ISPN 14 should support also the old annotations. I think we should update both within #14925. We can try to update this together?

@martin-kanis
Copy link
Contributor

It is related somehow to the annotations. If I remove following imports and related annotations from a HotRodEntity, I have less errors:

import org.infinispan.protostream.annotations.AutoProtoSchemaBuilder;
import org.infinispan.protostream.annotations.ProtoDoc;
import org.infinispan.protostream.annotations.ProtoField;

@martin-kanis
Copy link
Contributor

martin-kanis commented Nov 3, 2022

I narrowed it down to AutoProtoSchemaBuilder and this code block:

@AutoProtoSchemaBuilder(
            includeClasses = {
                    HotRodGroupEntity.class
            },
            schemaFilePath = "proto/",
            schemaPackageName = CommonPrimitivesProtoSchemaInitializer.HOT_ROD_ENTITY_PACKAGE,
            dependsOn = {CommonPrimitivesProtoSchemaInitializer.class}
    )

Do you have any idea what the problem might be?

All errors are like this:

/home/mkanis/workspace/keycloak/model/map-hot-rod/target/generated-sources/annotations/org/keycloak/models/map/storage/hotRod/singleUseObject/HotRodSingleUseObjectEntitySchemaImpl.java:[12,29] cannot find symbol
[ERROR]   symbol:   class Generated
[ERROR]   location: package javax.annotation.processing

@hmlnarik
Copy link
Contributor

All errors are like this:

/home/mkanis/workspace/keycloak/model/map-hot-rod/target/generated-sources/annotations/org/keycloak/models/map/storage/hotRod/singleUseObject/HotRodSingleUseObjectEntitySchemaImpl.java:[12,29] cannot find symbol
[ERROR]   symbol:   class Generated
[ERROR]   location: package javax.annotation.processing

This is caused by #15566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Indicates an issue that touches storage (change in data layout or data manipulation)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants