Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old administration console not loading #14288

Closed
pedroigor opened this issue Sep 8, 2022 · 3 comments · Fixed by #14328 or #14387
Closed

Old administration console not loading #14288

pedroigor opened this issue Sep 8, 2022 · 3 comments · Fixed by #14328 or #14387
Labels
area/admin/ui kind/bug Categorizes a PR related to a bug
Milestone

Comments

@pedroigor
Copy link
Contributor

Describe the bug

Looks like the old administration console is broken after this change #14271.

By reverting the changes, you should be able to access the old admin console as expected.

Version

999-SNAPSHOT

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response

@pedroigor pedroigor added kind/bug Categorizes a PR related to a bug status/triage labels Sep 8, 2022
@pedroigor
Copy link
Contributor Author

@jonkoops @ssilvert Any idea what might be happening? You get an error in the browser console but it is not clear what is happening. Just pointing to services.js.

@sschu
Copy link
Contributor

sschu commented Sep 9, 2022

@pedroigor @ssilvert @jonkoops I see syntax errors, something is broken with the nesting and IntelliJ also says it expects a ,and not closing brackets...

@stianst stianst added this to the 19.0.2 milestone Sep 9, 2022
@lexcao
Copy link
Contributor

lexcao commented Sep 11, 2022

I have reproduced from my local as well.

image

Attempt to fix from my local, this change would work.

query.callback({ results: response.map(function (client) {
    return { id: client.id, text: client.clientId }
-});
+})});

I am going to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin/ui kind/bug Categorizes a PR related to a bug
Projects
None yet
5 participants