Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test state partitioning in 3rd party iframes #14761

Open
jonkoops opened this issue Oct 6, 2022 · 1 comment
Open

Test state partitioning in 3rd party iframes #14761

jonkoops opened this issue Oct 6, 2022 · 1 comment
Assignees
Labels
area/adapter/javascript area/oidc Indicates an issue on OIDC area area/testsuite Indicates an issue on the Testsuite area kind/enhancement Categorizes a PR related to an enhancement priority/normal team/core-clients

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Oct 6, 2022

Tests should be written to test access to 3rd party cookies and state partitioning. For more information see implementation in #14680.

@jonkoops jonkoops added area/oidc Indicates an issue on OIDC area area/testsuite Indicates an issue on the Testsuite area kind/enhancement Categorizes a PR related to an enhancement priority/important Must be worked on very soon area/adapter/javascript labels Oct 6, 2022
@vmuzikar
Copy link
Contributor

vmuzikar commented Oct 6, 2022

Just a couple of thoughts.

The partitioning should be fairly simple to trigger. All it takes is to set the hostname-admin to a different domain than frontend hostname. E.g.

./kc.sh start-dev --hostname=frontend-127-0-0-1.nip.io --hostname-admin=localhost

In this case, login flow will run on frontend-127-0-0-1.nip.io but the admin console (simulating a client app) will be on localhost.

We should also add some tests for the cookies fallback for when the storage API is unavailable. This might be a bit tricky and might require an older browser.

But in general, IMHO we should be testing with the latest (even beta/dev) browsers to know as soon as possible they restricted something even more, to avoid more issues like #14466 in the future.

@jonkoops jonkoops self-assigned this May 11, 2023
@jonkoops jonkoops added priority/normal and removed priority/important Must be worked on very soon labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/adapter/javascript area/oidc Indicates an issue on OIDC area area/testsuite Indicates an issue on the Testsuite area kind/enhancement Categorizes a PR related to an enhancement priority/normal team/core-clients
Projects
None yet
Development

No branches or pull requests

3 participants