Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator Support for missing leading slash and present trailing slash in http-relative-path #16800

Closed
vmuzikar opened this issue Feb 2, 2023 · 3 comments
Labels
area/operator Keycloak.X Operator kind/enhancement Categorizes a PR related to an enhancement
Milestone

Comments

@vmuzikar
Copy link
Contributor

vmuzikar commented Feb 2, 2023

This is a follow-up from #16736.

The Operator needs to support:

  • missing leading slash, e.g. auth
  • present trailing slash, e.g. auth/
  • the combination of both, e.g. /auth/

Currently, the Operator expects the http-relative-path to have only leading slash (/auth).

@vmuzikar vmuzikar added kind/enhancement Categorizes a PR related to an enhancement area/operator Keycloak.X Operator labels Feb 2, 2023
@vmuzikar vmuzikar added this to the 22.0.0 milestone Feb 2, 2023
@nrobert13
Copy link

Another thing to consider, is that if you use custom image with the operator, it will automatically add --optimized to start, which means that the build options configured by the operator won't have any effect. This was the problem in my case. I had to add the relative-path to the custom image. So maybe either make the --optimized configurable in the operator, or log some messages regarding the build option during startup.

@shawkins
Copy link
Contributor

Duplicate of #17388

@shawkins shawkins marked this as a duplicate of #17388 Jun 26, 2023
@vmuzikar
Copy link
Contributor Author

vmuzikar commented Jun 27, 2023

@shawkins Closing as not planned to avoid spamming the release notes. :)

@vmuzikar vmuzikar closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator Keycloak.X Operator kind/enhancement Categorizes a PR related to an enhancement
Projects
Status: Done
Development

No branches or pull requests

3 participants