Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Removing aria-label set to empty string in all switches and an issue with announcing labels when moving using arrow keys #18111

Closed
agagancarczyk opened this issue Aug 24, 2022 · 0 comments
Assignees
Labels
impact/low kind/bug Categorizes a PR related to a bug team/ui

Comments

@agagancarczyk
Copy link
Contributor

Describe the bug

Reported issue details: The enabled checkbox has an empty aria-label (e. g. explicitly set to an empty string) and an aria-labelledby attribute. No idea whether that is the reason for the behavior, but the label is not announced in Firefox when moving using the arrow keys in browse mode, but is announced when moving using the tab key in whatever mode. This behavior unfortunately applies to all checkboxes throughout the admin interface.

The tester was using NVDA Alpha 26228 tool.

Testing device details:

  • Windows 10, build 19044.1889
  • Firefox 103.0.2 or Microsoft Edge 104.0.1293.54

Note: I have investigated this issue on MacbookPro, Chrome browser and ChromeVox extension and while I was able to see the empty aria-label I was not able to replicate the label not being announced when moving using the arrow keys This is because I don't know how the tester was using the arrow keys to navigate (it could be specific to NVDA tool I'm not able to use on MacbookPro, I will get more info upon meeting with the tester and will update this issue).

Screenshot 2022-08-24 at 13 25 22

Version

19.0.0

Expected behavior

The labels for switches should be announced in Firefox when moving using the arrow keys.

Actual behavior

The labels for switches are not announced in Firefox when moving using the arrow keys.

How to Reproduce?

  • Switch to the newly created realm using the dropdown in the left-side menu
  • Click on the Realm settings in the left-side menu
  • Click on the hint button (question mark in a circle) at one of the fields in the General tab i.e Frontend URL

Anything else?

No response

@agagancarczyk agagancarczyk added kind/bug Categorizes a PR related to a bug impact/low labels Aug 24, 2022
@agagancarczyk agagancarczyk changed the title Accessibility: Removing aria-label set to empty string in all switches Accessibility: Removing aria-label set to empty string in all switches and announcing labels when moving using arrow keys Aug 24, 2022
@agagancarczyk agagancarczyk self-assigned this Aug 29, 2022
@agagancarczyk agagancarczyk changed the title Accessibility: Removing aria-label set to empty string in all switches and announcing labels when moving using arrow keys Accessibility: Removing aria-label set to empty string in all switches and an issue with announcing labels when moving using arrow keys Aug 30, 2022
@ssilvert ssilvert transferred this issue from another repository Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/low kind/bug Categorizes a PR related to a bug team/ui
Projects
None yet
Development

No branches or pull requests

2 participants