Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show/hide password in clear text button visible for hiden field in "forgot password" flow #24487

Closed
1 task done
BlackVoid opened this issue Nov 2, 2023 · 4 comments · Fixed by #24489
Closed
1 task done
Assignees
Labels
Milestone

Comments

@BlackVoid
Copy link
Contributor

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

account/ui

Describe the bug

When using the reset password flow the button to toggle between showing and hiding the password is shown for a hidden field as shown in the image below
image

Version

nightly (2023-10-02)

Expected behavior

The toggle should not be shown for hidden fields

Actual behavior

The toggle is visible for a hidden field

How to Reproduce?

  1. Create a user
  2. Use the forgot password feature
  3. Click on the link to reset password
  4. The toggle for a hidden field is shown

Anything else?

No response

@BlackVoid BlackVoid added kind/bug Categorizes a PR related to a bug status/triage labels Nov 2, 2023
@jonkoops jonkoops added this to the 23.0.0 milestone Nov 2, 2023
@jonkoops jonkoops self-assigned this Nov 2, 2023
@jonkoops
Copy link
Contributor

jonkoops commented Nov 2, 2023

I am able to reproduce this issue, I'll work on a fix.

@jonkoops
Copy link
Contributor

jonkoops commented Nov 2, 2023

Fix available under #24489, this will land in v23.

@BlackVoid
Copy link
Contributor Author

That was super fast, thanks you!

@jonkoops
Copy link
Contributor

jonkoops commented Nov 2, 2023

Keeping this issue open, as we need to land this fix first.

@jonkoops jonkoops reopened this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants