New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Vite #6
Move to Vite #6
Conversation
mkreuzmayr
commented
Mar 23, 2023
•
edited
edited
- Move starter project to Vite using features of #275
- Adding and running Prettier with keycloakify config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm divided on adding Prettier, on one hand it's conveignent to have it but on the other it seems a bit out of scope and it's something more to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But on the other end I used to be the only one maintaining this repo, now that you guys are getting involved it's good to have prettier I guess...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, it was a nightmare to convert this repository because it had no consistent formatting.
Prettier does not really ned to be maintained, once set up it normally does not need to be touched until there is a formatting settings change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my two cents: prettier is awesome but I loathe that it adds TWO config files 😅
- instead of prettierignore you could add this to package.json https://stackoverflow.com/a/66409885
- move prettierrc into package.json
but ofc thats personal preference, ill go with whatever you guys prefer
@mkreuzmayr Hi, Have you planned to finish this migration to Vite ? Thanks for your help |
Hello @h-bessa, |
Thanks, didin't see the update ;). |