Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Vite #6

Closed
wants to merge 2 commits into from
Closed

Move to Vite #6

wants to merge 2 commits into from

Conversation

mkreuzmayr
Copy link
Collaborator

@mkreuzmayr mkreuzmayr commented Mar 23, 2023

  • Move starter project to Vite using features of #275
  • Adding and running Prettier with keycloakify config

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm divided on adding Prettier, on one hand it's conveignent to have it but on the other it seems a bit out of scope and it's something more to maintain.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But on the other end I used to be the only one maintaining this repo, now that you guys are getting involved it's good to have prettier I guess...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, it was a nightmare to convert this repository because it had no consistent formatting.
Prettier does not really ned to be maintained, once set up it normally does not need to be touched until there is a formatting settings change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my two cents: prettier is awesome but I loathe that it adds TWO config files 😅

but ofc thats personal preference, ill go with whatever you guys prefer

@h-bessa
Copy link

h-bessa commented Feb 14, 2024

@mkreuzmayr Hi, Have you planned to finish this migration to Vite ?
I've sent you an email to understand where are the pain points.

Thanks for your help

@garronej
Copy link
Collaborator

Hello @h-bessa,
The migration to vite is done already.
Look on main, it's a vite project.

@garronej garronej closed this Feb 14, 2024
@h-bessa
Copy link

h-bessa commented Feb 14, 2024

Thanks, didin't see the update ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants