-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run keycloakify behind corporate proxy #257
Comments
the stack trace is a bit short, so its hard to figure out which command exactly fails, but I have a hunch that its this call here https://github.com/InseeFrLab/keycloakify/blob/main/src/bin/tools/downloadAndUnzip.ts#L69 It should be adapted to support proxies like this https://stackoverflow.com/a/6781592 @garronej I can take a swing at it some time next week |
Hey @lordvlad, |
Fixes #257 Use make-fetch-happen for the download step. This lib will use `PROXY` and `HTTPS_PROXY` and `NO_PROXY` env vars out of the box. Additionally we'll try and get proxy config from npm. Unfortunately, the most straightforward options is to call npm config to do this, since npm config is not easily extracted as a lib and we don't want to replicate the resolution mechanisms.
@boldt I tested my implementation with squid proxy on localhost, let me know how it works for you |
@boldt EDIT: Sorry it's 6.13.0-rc.0 that contains the changes |
The release 6.13.0-rc.0 is not available via npm yet: |
My bad! it's available now. |
I still can't see it on npm: https://www.npmjs.com/package/keycloakify?activeTab=versions |
sorry for all the back en forth, I don't understand what whent up with the CI. |
That version works. Thanks! |
Great thank you for the feedback, I'll release then |
If I run keycloakify behind a corporate proxy, I get the following error:
Note
The npm config vars
https-proxy
,no-proxy
andproxy
are set and work well for the dependency installation and within other projects.The text was updated successfully, but these errors were encountered: