-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add login-config-totp.ftl page #127
Conversation
Wonderfull, thank you very much, looks clean. |
My pleasure! Let me know if you have any questions or need any changes. |
@aidangilmore, |
I released a new version including your changes. |
I tested using I didn't have any major issue following the contributing document, just a small one caused by the versions of React not lining up between Keycloakify It wasn't entirely clear how to get the types for KcContextBase, so I just looked at the Keycloak source code and used the types from there. If there is a better way of doing this, it may be worth mentioning in the doc. I will say that I really liked that you pointed to a sample commit that I could base my changes off of. Does that answer your questions? |
Yes, thank you for the lovely feedback.
It makes sense that you had issues linking react, I forgot, Keycloakify is still using 17 when the demo app is using 18. I'll correct this.
No, unfortunately there is no better way than to infer from usage just like you did.
OK good to know! Thanks again for taking the time to contribute to Keycloakify! |
@all-contributors please add @aidangilmore for tests and code |
I've put up a pull request to add @aidangilmore! 🎉 |
Adds
login-config-totp.ftl
page, resolving #102