windows compatibility #226
Conversation
lordvlad
changed the title
lordvlad
changed the title
lordvlad
changed the title
| * @param dir target directory | ||
| * @returns promise for the full path of the downloaded file | ||
| */ | ||
| async function download(url: string, dir: string): Promise<string> { |
There was a problem hiding this comment.
It might seem unorthodox to implement this from scratch, but really, introducing another library was not worth it IMHO
There was a problem hiding this comment.
Agreed, mutch apreciated!
| pathOfDirToExtractInArchive?: string; | ||
| cacheDirPath: string; | ||
| }) { | ||
| const downloadHash = hash(JSON.stringify({ url, pathOfDirToExtractInArchive })).substring(0, 15); |
There was a problem hiding this comment.
This is now a bit different to your previous cachin strategy, let me know what you think of it
There was a problem hiding this comment.
LGTM in surface.
I didn't test if it actually work though...
I'll trust you on that.
| var { bin } = await import(pathJoin(getProjectRoot(), "package.json")); | ||
|
|
||
| var promises = Object.values<string>(bin).map(async scriptPath => { | ||
| const fullPath = pathJoin(getProjectRoot(), scriptPath); |
There was a problem hiding this comment.
a bit more synchronous, eh? :)
|
Thank you so much for this work. |
|
Bummer, it dosen't work. here is an invite on for the repo so you can push on the branch: https://github.com/InseeFrLab/keycloakify/invitations |
|
@garronej whats broken? it worked for me and github actions were all green? |
|
@lordvlad I'm very very sorry 🙇🏼♂️ |
|
Again @lordvlad, |
|
haha all good. happy to make an improvement
…On Mon, Jan 30, 2023 at 1:18 AM Joseph Garrone ***@***.***> wrote:
Again @lordvlad <https://github.com/lordvlad>,
I wanted to reiterate and tell you how very sorry I am to call your PR
broken when it was I that didn’t run the right command.
Your effort is very much appreciated!
—
Reply to this email directly, view it on GitHub
<#226 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJJ2N6363G2H36Y6KMJOTWU4CGTANCNFSM6AAAAAATZWXPJY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Chown does not exist on widows. This PR uses nodejs's native fs.chmodSync instead