Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds alembic dependency (Fixed missing , ) #20

Merged
merged 5 commits into from Oct 27, 2020
Merged

Conversation

RUKip
Copy link
Contributor

@RUKip RUKip commented Oct 21, 2020

Adds alembic dependency and fixes typo. Part of issue: #19

Copy link
Member

@mpeters mpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mpeters
Copy link
Member

mpeters commented Oct 23, 2020

CI is currently failing because of a previous (unrelated commit). Opening separate issue to track: #21

* Remove Fedora 30 tests since it's EOL.

* Remove task that installed keylime.conf
  This is now handled by the rpm package installed by dnf.
  Since this is the last task in keylime.yml, just consolidate
  everything back into main.yml

* Fix missing comma in package list
@mpeters
Copy link
Member

mpeters commented Oct 26, 2020

@RUKip would you mind rebasing your PR and then re-pushing? I've fixed the issues with the CI but in order for your PR to pick up the travis CI configuration it needs to be rebased.

@RUKip
Copy link
Contributor Author

RUKip commented Oct 27, 2020

@mpeters Now passes!

@mpeters mpeters merged commit c38e0f9 into keylime:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants