Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifier seems to read registrar.conf #1446

Closed
kkaarreell opened this issue Aug 4, 2023 · 2 comments
Closed

verifier seems to read registrar.conf #1446

kkaarreell opened this issue Aug 4, 2023 · 2 comments
Assignees
Labels

Comments

@kkaarreell
Copy link
Contributor

Is your issue a feature request? If so, please raise it as an enhancement

Environment

  • OS / version: Fedora 38
  • Processor architecture: x86_64
  • TPM Manufacturer: swtpm
  • Keylime version: upstream (901f22d)

Description

verifier log suggests that the verifier is reading registrar.conf and there is also some output that suggests (even though it may not be true) db settings is loaded. This is not happening with registrar.

keylime_verifier[3357]: INFO:keylime.config:Reading configuration from ['/etc/keylime/logging.conf']
keylime_verifier[3357]: 2023-08-02 08:02:50.325 - keylime.config - INFO - Reading configuration from ['/etc/keylime/verifier.conf']
keylime_verifier[3357]: 2023-08-02 08:02:50.326 - keylime.failure - INFO - Severity configuration set
keylime_verifier[3357]: 2023-08-02 08:02:50.326 - keylime.keylime_db - INFO - database_url is set, using it to establish database connection
keylime_verifier[3357]: 2023-08-02 08:02:50.326 - keylime.keylime_db - INFO - database_url is set as 'sqlite' keyword, using default values to establish database connection
keylime_verifier[3357]: 2023-08-02 08:02:50.331 - keylime.config - INFO - Reading configuration from ['/etc/keylime/registrar.conf']
keylime_verifier[3357]: 2023-08-02 08:02:50.408 - keylime.keylime_db - INFO - database_url is set, using it to establish database connection
keylime_verifier[3357]: 2023-08-02 08:02:50.409 - keylime.keylime_db - INFO - database_url is set as 'sqlite' keyword, using default values to establish database connection
keylime_verifier[3357]: 2023-08-02 08:02:50.409 - alembic.env - INFO - Migrating database cloud_verifier
keylime_verifier[3357]: 2023-08-02 08:02:50.410 - alembic.runtime.migration - INFO - Context impl SQLiteImpl.
keylime_verifier[3357]: 2023-08-02 08:02:50.410 - alembic.runtime.migration - INFO - Will assume non-transactional DDL.
keylime_verifier[3357]: 2023-08-02 08:02:50.416 - keylime.measured_boot - DEBUG - mba.elchecking.elchecker: policy names = ['accept-all', 'reject-all']
keylime_verifier[3357]: 2023-08-02 08:02:50.417 - keylime.keylime.cmd_exec - DEBUG - Executing command "tpm2_startup --version"
keylime_verifier[3357]: 2023-08-02 08:02:50.423 - keylime.elparsing - DEBUG - mba.elparser.tpm2_tools_elparser: TPM2-TOOLS 5.4 detected.
keylime_verifier[3357]: 2023-08-02 08:02:50.423 - keylime.verifier - WARNING - The configuration upgrade templates path /usr/share/keylime/templates does not exist
keylime_verifier[3357]: 2023-08-02 08:02:50.433 - keylime.verifier - INFO - Starting Cloud Verifier (tornado) on port 8881, use <Ctrl-C> to stop
keylime_verifier[3357]: 2023-08-02 08:02:50.433 - keylime.verifier - INFO - Current API version 2.1
keylime_verifier[3357]: 2023-08-02 08:02:50.433 - keylime.verifier - INFO - Supported older API versions: 1.0, 2.0
keylime_verifier[3357]: 2023-08-02 08:02:50.433 - keylime.verifier - INFO - Deprecated API versions (soon to be removed): 1.0
keylime_verifier[3357]: 2023-08-02 08:02:50.433 - keylime.verifier - INFO - Setting up TLS...
keylime_verifier[3357]: 2023-08-02 08:02:50.433 - keylime.config - INFO - Reading configuration from ['/etc/keylime/ca.conf']

Expected behavior vs. actual behavior

registrar.conf won't be read

Steps to reproduce problem

  1. start verifier and see the log
@THS-on THS-on added the bug label Aug 5, 2023
@THS-on THS-on self-assigned this Aug 5, 2023
@ansasaki
Copy link
Contributor

I believe this was introduced in 383c56a:

rmc = record.get_record_mgt_class(config.get("registrar", "durable_attestation_import", fallback=""))

@maugustosilva
Copy link
Contributor

ooops, that is squarely on me. Thanks for diagnosing @ansasaki, I will have a PR soon.

maugustosilva pushed a commit to maugustosilva/keylime that referenced this issue Aug 23, 2023
Signed-off-by: Marcio Silva <marcio.a.silva@ibm.com>
maugustosilva pushed a commit to maugustosilva/keylime that referenced this issue Aug 23, 2023
The verifier should read "durable attestation" backend imports from
verifier.conf (and NOT from registrar.conf)

Signed-off-by: Marcio Silva <marcio.a.silva@ibm.com>
maugustosilva pushed a commit to maugustosilva/keylime that referenced this issue Aug 23, 2023
Single-line fix for keylime#1446

The verifier should read "durable attestation" backend imports from
verifier.conf (and NOT from registrar.conf)

Signed-off-by: Marcio Silva <marcio.a.silva@ibm.com>
maugustosilva pushed a commit that referenced this issue Aug 23, 2023
Single-line fix for #1446

The verifier should read "durable attestation" backend imports from
verifier.conf (and NOT from registrar.conf)

Signed-off-by: Marcio Silva <marcio.a.silva@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants