Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm_cert_store: add the Alibaba Cloud vTPM EK x509 cert #1448

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

Jingshui1037
Copy link

Adding the Alibaba Cloud vTPM EK Cert to the tpm_cert_store directory can reduce the need for users to manually import certificates when using keylime on Alibaba Cloud, making it more user-friendly.

Besides, the Alibaba Cloud vTPM EK x509 cert can be downloaded at https://aliyun-tpm-ca.oss-cn-beijing.aliyuncs.com/pki001/ekmf-ca.crt

Signed-off-by: YiLin.Li YiLin.Li@linux.alibaba.com

Adding the Alibaba Cloud vTPM EK Cert to the tpm_cert_store directory can
reduce the need for users to manually import certificates when using
keylime on Alibaba Cloud, making it more user-friendly.

Besides, the Alibaba Cloud vTPM EK x509 cert can be downloaded at
https://aliyun-tpm-ca.oss-cn-beijing.aliyuncs.com/pki001/ekmf-ca.crt

Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1448 (4733ace) into master (7168905) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
Flag Coverage Δ
packit-e2e 72.20% <ø> (ø)
testsuite 29.87% <ø> (ø)
unittests 7.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@aplanas aplanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the YAML code gets ignored. Did you try this?

Otherwise LGTM

@Jingshui1037
Copy link
Author

Hi @aplanas

Thanks for your review. If I don't add the Alibaba Cloud vTPM EK x509 cert manually, I will get the error like this with the keylime_tenant tool.

image

After adding this cert, this error can be fixed like this

image

@maugustosilva maugustosilva merged commit 25c1aa0 into keylime:master Aug 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants