requirements.txt: update the need sqlalchemy version to 1.3.12 and above. #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove. When the SQLAlchemy version is less than 1.3.11, there is an error like this `File "/usr/local/lib/python3.6/site-packages/alembic/ddl/sqlite.py", line 56, in requires_recreate_in_batch and col.server_default.persisted AttributeError: 'NoneType' object has no attribute 'persisted'` The sqlalchemy/alembic repo fix compat issue with older SQLAlchemy versions in sqlalchemy/alembic@2866272 and point the issue is caused by the lower SQLAlchemy version (less than SQLAlchemy 1.3.11) so it's better for us to update the need SQLAlchemy version from 1.3 to 1.3.12 or update the need alembic version from 1.1.0 to 1.11.0. Obviouly, update the need sqlalchemy version to 1.3.12 and above is better than update the need alembic version to 1.11.0. Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
aplanas
approved these changes
Aug 14, 2023
THS-on
approved these changes
Aug 14, 2023
sergio-correia
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SQLAlchemy version is less than 1.3.11, there is an error like this
File "/usr/local/lib/python3.6/site-packages/alembic/ddl/sqlite.py", line 56, in requires_recreate_in_batch and col.server_default.persisted AttributeError: 'NoneType' object has no attribute 'persisted'The sqlalchemy/alembic repo fix compat issue with older SQLAlchemy versions in
sqlalchemy/alembic@2866272 and point the issue is caused by the lower SQLAlchemy version (less than SQLAlchemy 1.3.11)
so it's better for us to update the need SQLAlchemy version from 1.3 to 1.3.12 or update the need alembic version from 1.1.0 to 1.11.0. Obviouly, update the need sqlalchemy version to 1.3.12 and above is better than update the need alembic version to 1.11.0.
Fixes #1453
Signed-off-by: YiLin.Li YiLin.Li@linux.alibaba.com