Close session in worker_webhook function #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a Packit service outage and therefore Packit tests have not been started yet. |
|
/packit test |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stefanberger
approved these changes
Aug 15, 2023
sergio-correia
approved these changes
Aug 15, 2023
aplanas
reviewed
Aug 15, 2023
keylime/revocation_notifier.py
Outdated
| @@ -159,6 +159,8 @@ def worker_webhook(tosend: Dict[str, Any], url: str) -> None: | |||
|
|
|||
| time.sleep(next_retry) | |||
|
|
|||
| session.close() | |||
There was a problem hiding this comment.
I think that a bit more correct fix is to use the context manager: https://requests.readthedocs.io/en/latest/user/advanced/#session-objects
kkaarreell
changed the title
stefanberger
approved these changes
Aug 15, 2023
Resolves keylime#1455 Signed-off-by: Karel Srot <ksrot@redhat.com>
Signed-off-by: Karel Srot <ksrot@redhat.com>
kkaarreell
force-pushed
the
ks_issue1455
branch
from
1b4a240
to
47b7d0c
Compare
|
I have just merged two commits. |
sergio-correia
approved these changes
Aug 15, 2023
aplanas
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1455