Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pylint C0103 (naming) errors in some files #1478

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

purujit
Copy link

@purujit purujit commented Oct 4, 2023

Contributing to #929

@purujit purujit mentioned this pull request Oct 4, 2023
39 tasks
@purujit purujit requested a review from THS-on October 4, 2023 19:09
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1478 (185889f) into master (1370326) will increase coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 73.80%.

Additional details and impacted files
Flag Coverage Δ
packit-e2e 71.02% <73.80%> (+0.02%) ⬆️
testsuite 29.24% <45.23%> (-0.02%) ⬇️
unittests 7.62% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
keylime/agentstates.py 90.00% <100.00%> (ø)
keylime/crypto.py 86.27% <50.00%> (-1.49%) ⬇️
keylime/db/keylime_db.py 86.95% <60.00%> (ø)
keylime/api_version.py 72.60% <83.33%> (ø)
keylime/cert_utils.py 90.80% <60.00%> (ø)

... and 1 file with indirect coverage changes

@stefanberger
Copy link
Contributor

I sent PR #1479 to address these pyright issues. Once that is in you should rebase on top of it.

@THS-on
Copy link
Member

THS-on commented Oct 5, 2023

@purujit you can now rebase on master. I've merged #1479

@purujit
Copy link
Author

purujit commented Oct 5, 2023

@THS-on I have rebased now.

@THS-on
Copy link
Member

THS-on commented Oct 5, 2023

Thanks. Can you also squash the two commits together and remove one of the signoff lines? Because currently you have signed off the first commit with two different email addresses.

Signed-off-by: MC Dubbs <mcdubbs@gmail.com>
@purujit
Copy link
Author

purujit commented Oct 5, 2023

Thanks. Can you also squash the two commits together and remove one of the signoff lines? Because currently you have signed off the first commit with two different email addresses.

Done

keylime.web_util.echo_json_response(self, 400, "Exception error: %s" % e)
logger.warning("POST returning 400 response. Exception error: %s" % e)
logger.exception(e)
except Exception as err:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my curiosity, what was the complain here, a single char variable name? I am reading the C0103 documentation but I do not see a good candidate.

i, e, x, y are very used as local variables, if pylint complain if somehow a bit unfair

@stefanberger stefanberger merged commit 8b5decd into keylime:master Oct 5, 2023
11 of 12 checks passed
@THS-on THS-on added the cleanup label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants