-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pylint C0103 (naming) errors in some files #1478
Fix pylint C0103 (naming) errors in some files #1478
Conversation
ea913bb
to
088b060
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I sent PR #1479 to address these pyright issues. Once that is in you should rebase on top of it. |
290eec8
to
185889f
Compare
@THS-on I have rebased now. |
Thanks. Can you also squash the two commits together and remove one of the signoff lines? Because currently you have signed off the first commit with two different email addresses. |
Signed-off-by: MC Dubbs <mcdubbs@gmail.com>
185889f
to
6914ce7
Compare
Done |
keylime.web_util.echo_json_response(self, 400, "Exception error: %s" % e) | ||
logger.warning("POST returning 400 response. Exception error: %s" % e) | ||
logger.exception(e) | ||
except Exception as err: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my curiosity, what was the complain here, a single char variable name? I am reading the C0103 documentation but I do not see a good candidate.
i, e, x, y are very used as local variables, if pylint complain if somehow a bit unfair
Contributing to #929