db: only set length on Text type if supported #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL does not support Text with a length MySQL does. Signed-off-by: Thore Sommer <mail@thson.de>
bnevis-i
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
LGTM. No errors on the fix branch.
Dec 22 09:59:52 keylime-v systemd[1]: Started keylime_verifier.service.
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: Using config file /etc/keylime.conf
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.694 - keylime.keylime_db - INFO - database_url is not set, using multi-parameter database configuration options
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.749 - keylime.keylime_db - INFO - database_url is not set, using multi-parameter database configuration options
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.763 - alembic.env - INFO - Migrating database cloud_verifier
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.763 - alembic.runtime.migration - INFO - Context impl PostgresqlImpl.
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.764 - alembic.runtime.migration - INFO - Will assume transactional DDL.
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.782 - alembic.runtime.migration - INFO - Running upgrade -> 8a44a4364f5a, Initial database migration
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.790 - alembic.runtime.migration - INFO - Running upgrade 8a44a4364f5a -> eeb702f77d7d, allowlist rename
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.791 - alembic.runtime.migration - INFO - Running upgrade eeb702f77d7d -> 8da20383f6e1, extend_ip_field
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.792 - alembic.runtime.migration - INFO - Running upgrade 8da20383f6e1 -> a7a64155ab3a, Add ima_sign_verification_keys column
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.793 - alembic.runtime.migration - INFO - Running upgrade a7a64155ab3a -> cc2630851a1f, receive the aik_tpm from the agent
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.793 - alembic.runtime.migration - INFO - Running upgrade cc2630851a1f -> ae898986c6e9, add_mb_refstate_column
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.794 - alembic.runtime.migration - INFO - Running upgrade ae898986c6e9 -> eb869a77abd1, create_allowlist_table
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.810 - alembic.runtime.migration - INFO - Running upgrade eb869a77abd1 -> b4d024197413, add_verfier_id_to_verifiermain_table
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.812 - alembic.runtime.migration - INFO - Running upgrade b4d024197413 -> f82c4252bc4f, Add ip and port to registrar
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.812 - alembic.runtime.migration - INFO - Running upgrade f82c4252bc4f -> 7d5db1a6ffb0, Add agentstates columns
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.814 - alembic.runtime.migration - INFO - Running upgrade 7d5db1a6ffb0 -> f35cdd35eb83, Move (v)tpm_policy to JSONPickleType
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.815 - alembic.runtime.migration - INFO - Running upgrade f35cdd35eb83 -> 257fe0f0c039, Add fields for revocation context to verifier
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.816 - alembic.runtime.migration - INFO - Running upgrade 257fe0f0c039 -> c3842cc9ee69, Store keyrings learned from IMA log
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.832 - keylime.cloudverifier - INFO - Starting Cloud Verifier (tornado) on port 8881, use <Ctrl-C> to stop
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.832 - keylime.cloudverifier - INFO - Current API version 1.0
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.833 - keylime.cloudverifier_common - INFO - Setting up TLS...
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.833 - keylime.cloudverifier_common - INFO - Existing CA certificate found in /var/lib/keylime/cv_ca, not generating a new one
Dec 22 09:59:52 keylime-v keylime_verifier[4976]: 2021-12-22 09:59:52.834 - keylime.cloudverifier - INFO - Starting service for revocation notifications on port 8992
maugustosilva
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL does not support Text with a length MySQL does.
Should fix #814