Allow graceful shutdown of the verifier #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeters
approved these changes
Jan 7, 2022
We now ensure that the revocation notifier is started and stopped by the same process. Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
THS-on
force-pushed
the
fix-verifier-termination
branch
from
6951268
to
3650a86
Compare
|
The Fedora 34 test is failing and cannot see why this change should have an impact on the agent quote status and it passes on centos 9. @kkaarreell maybe a timing issue between adding the agent and checking the agent state? |
|
/packit test |
|
Account kkaarreell has no write access nor is author of PR! |
|
@THS-on could you reschedule tests by adding the above comment? |
|
/packit test |
|
That last failure is due to occasional error during TPM setup. I think you can ignore it, usually test rerun passes. I am not sure what is the culprit but it is not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kkaarreell noticed that the shutdown of the verifier results in an error. This should fix that.