Move all Keylime web components to Tornado #835
Conversation
Signed-off-by: Thore Sommer <mail@thson.de>
The code is shared between registrar and verifier. Signed-off-by: Thore Sommer <mail@thson.de>
Instead of using the builtin HTTP server implementation of Python, Keylime now uses also the Tornado framework for the registrar. Signed-off-by: Thore Sommer <mail@thson.de>
This function is Tornado specific and is not required for configuration of Keylime, so it is moved into the tornado_helpers module. Signed-off-by: Thore Sommer <mail@thson.de>
THS-on
force-pushed
the
move-to-tornado
branch
from
73c5330
to
a8f0022
Compare
tornado_response was renamed to TornadoResponse. The json and yaml methods were removed because they were unsed. Signed-off-by: Thore Sommer <mail@thson.de>
The response object might not have error as a member. Signed-off-by: Thore Sommer <mail@thson.de>
THS-on
force-pushed
the
move-to-tornado
branch
from
a8f0022
to
f899287
Compare
|
@kkaarreell the test fails, but all individual steps have a PASS and 0 bad are reported, do you know why? |
|
/packit test |
|
Ok it seems that the tests reach a timeout of 15min, but I don't know why. |
|
@THS-on I can reproduce the problem locally. keylime_agent hung and didn't react on kill signal. However, I can reproduce it using this branch but not using the keylime master branch. Is there something in this PR that would explain it? |
|
I have update the test suite. It won't timeout but better check the test log to see that there hasn't been any traceback when the process has been terminated. |
|
@kkaarreell It is fine for me if the CI fails when stopping the services fails for some reason, but it should be visible in the logs. Moving the registrar and agent to Tornado seems to cause some timeouts, that I cannot get rid off. |
|
OK, I will partially revert the test update on Monday. I have realized that the former version could have masked some issues so it is possible those will become visible. |
|
Superseded by #837 |
|
@THS-on I have updated tests and also provided basic instructions on how to run them locally on a test system. |
We are currently using Tornado for the verifier, but not for the agent and registrar.
This PR moves the agent and registrar to Tornado and unifies the utilities used for Tornado in the
tornado_helpersmodule.