Add type hints and initial Mypy configuration #930
Conversation
Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
Signed-off-by: Thore Sommer <mail@thson.de>
| _sub_components: Optional[List[str]] | ||
|
|
||
| def __init__(self, component, sub_components=None): | ||
| def __init__(self, component: Component, sub_components: Optional[List[str]] = None): |
There was a problem hiding this comment.
Just a question on style here: Does the type hints syntax prefer whitespace around the equals sign?
There was a problem hiding this comment.
I think so: https://peps.python.org/pep-3107/#parameters.
|
Overall I like this change as it should prevent some accidental bugs in the future. Being unfamiliar with Mypy, are there any performance considerations? |
Type hints are ignored at runtime, so there should be no performance impact other than the hints are getting parsed and then ignored. |
|
/packit test |
|
@kkaarreell why did this e2e CI pass? |
|
There is some issue with tmt plan on c9s and c8s where prepare steps are replaced, not added. As a result c8s and c9s are run against upstream master. I have just found out few minutes back. |
This PR adds full type hints to:
ima_ast.pyfailure.pyalgorithms.pykeylime_loggin.pyjson.pyI also added a Mypy configuration with
strictset to true which should enable most of the Mypy checks.Once more parts of Keylime have type hints I will add this to the tox configuration.
Part of #929