Add create_ek() to tpm.rs #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puiterwijk
reviewed
Nov 12, 2020
src/tpm.rs
Outdated
| let alg = match alg { | ||
| Some(a) => a, | ||
| None => { | ||
| // TODO: What other values could be in keylime.conf? |
There was a problem hiding this comment.
I think the only other value we should consider correct is ecc.
I'd say that the _ => should return an error instead.
lkatalin
force-pushed
the
ekcreate
branch
2 times, most recently
from
8f5023c
to
9fd1faf
Compare
|
Here is an updated PR with an error for encryption algorithms other than rsa and ecc, and retrieving the TPM pub object and turning it into a I don't think that turning the TPM pub object into a |
lkatalin
force-pushed
the
ekcreate
branch
2 times, most recently
from
5e864b4
to
a090d7d
Compare
puiterwijk
approved these changes
Nov 23, 2020
Signed-off-by: Lily Sturmann <lsturman@redhat.com>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this needs more functionality, different return types, etc., please let me know.