Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update images and instructions to 17.0 #1148

Merged
merged 11 commits into from Apr 3, 2024

Conversation

Meng-Heng
Copy link
Collaborator

@Meng-Heng Meng-Heng commented Mar 25, 2024

Please approve this PR #1147 before reviewing this.

Sections that need experts to add information or give me context:

  1. context/model-editor ✅
    • #details-tab is missing some instruction
  2. context/new-project ✅
    • LDML keyboard needs an instruction
  3. context/options (another PR)
    • Server tab needs an update
  4. context/startup (deleted)

@Meng-Heng Meng-Heng added this to the B17S4 milestone Mar 25, 2024
@Meng-Heng Meng-Heng self-assigned this Mar 25, 2024
@darcywong00
Copy link
Contributor

You'll want to merge master to this branch to get the images from #1147

@mcdurdin mcdurdin modified the milestones: B17S4, B17S5 Mar 30, 2024

Keyman Developer Server
: *update soon*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe PR keymanapp/keyman#6073 documents features of the Keyman Developer Server which is used for testing and debugging keyboards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of info, so that could go on separate PR if you want

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will update this section on another PR.

Co-authored-by: Darcy Wong <darcy_wong@sil.org>
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darcywong00 darcywong00 merged commit 5b5ddc3 into keymanapp:master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants