Skip to content

Commit

Permalink
fix(developer): Improve active tab visibility
Browse files Browse the repository at this point in the history
Fixes #845.
Fixes #3224.

Makes the active tab more visible both in the horizontal file tabs, and
in the vertical activity tabs by changing the background colour to
Keyman Light Blue (css: `#79C3DA`).
  • Loading branch information
mcdurdin committed Mar 1, 2022
1 parent 623cab7 commit e078440
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
1 change: 1 addition & 0 deletions windows/src/global/delphi/comp/CloseButtonPageControl.pas
Expand Up @@ -378,6 +378,7 @@ procedure TCloseButtonPageControl.DrawTab(TabIndex: Integer; const Rect: TRect;
CloseBtnRect.Top := Rect.Top + 4;
CloseBtnRect.Right := Rect.Right - 5;
TabCaption.X := Rect.Left + 6;
Canvas.Brush.Color := $DAC379; // Keyman Light Blue
end
else
begin
Expand Down
23 changes: 12 additions & 11 deletions windows/src/global/delphi/comp/LeftTabbedPageControl.pas
@@ -1,18 +1,18 @@
(*
Name: LeftTabbedPageControl
Copyright: Copyright (C) SIL International.
Documentation:
Description:
Documentation:
Description:
Create Date: 4 May 2015
Modified Date: 24 Jul 2015
Authors: mcdurdin
Related Files:
Dependencies:
Related Files:
Dependencies:
Bugs:
Todo:
Notes:
Bugs:
Todo:
Notes:
History: 04 May 2015 - mcdurdin - I4693 - V9.0 - Fix crash when creating left tabbed page control without images
24 Jul 2015 - mcdurdin - I4796 - Refresh Keyman Developer look and feel for release
*)
Expand Down Expand Up @@ -126,10 +126,11 @@ procedure TLeftTabbedPageControl.DrawTab(TabIndex: Integer; const Rect: TRect;
begin
TabIndex := GetPageIndexFromTabIndex(TabIndex);

// ARect := Rect;
// InflateRect(ARect, 4, 4);
// Canvas.Brush.Color := $c0c000;
// Canvas.FillRect(ARect);
if Active then
begin
Canvas.Brush.Color := $DAC379; // Keyman Light Blue
Canvas.FillRect(Rect);
end;

if Images <> nil then // I4693
Images.Draw(Canvas,
Expand Down

0 comments on commit e078440

Please sign in to comment.