Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded code path de-obfuscation needed #106

Closed
jahorton opened this issue Jun 26, 2017 · 1 comment
Closed

Embedded code path de-obfuscation needed #106

jahorton opened this issue Jun 26, 2017 · 1 comment
Labels
Milestone

Comments

@jahorton
Copy link
Contributor

In prep for open-sourcing our KMEA/KMEI code and relocating it to this repo, it's noteworthy that we could use some cleanup and refactoring of the embedded-related code paths existing in KMW.

A few note-worthy points:

  • keymanweb.fullInitialization is basically just an inverted keymanweb.embedded flag, but isn't nearly as explicit.
  • The util.wait function is only ever declared for 'native' mode and basically serves as an embedded marker; the code has a lot of if(typeof(util.wait) == 'function') tests that equate to if(!keymanweb.embedded).
  • Accordingly, the code would be simplified if we change those tests to use of the embedded flag and also create an empty stub function for util.wait and util.alert in kmwembedded.js that does nothing.
@jahorton
Copy link
Contributor Author

Fixed with #211.

@mcdurdin mcdurdin added this to the Support milestone Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants