You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In prep for open-sourcing our KMEA/KMEI code and relocating it to this repo, it's noteworthy that we could use some cleanup and refactoring of the embedded-related code paths existing in KMW.
A few note-worthy points:
keymanweb.fullInitialization is basically just an inverted keymanweb.embedded flag, but isn't nearly as explicit.
The util.wait function is only ever declared for 'native' mode and basically serves as an embedded marker; the code has a lot of if(typeof(util.wait) == 'function') tests that equate to if(!keymanweb.embedded).
Accordingly, the code would be simplified if we change those tests to use of the embedded flag and also create an empty stub function for util.wait and util.alert in kmwembedded.js that does nothing.
The text was updated successfully, but these errors were encountered:
In prep for open-sourcing our KMEA/KMEI code and relocating it to this repo, it's noteworthy that we could use some cleanup and refactoring of the embedded-related code paths existing in KMW.
A few note-worthy points:
keymanweb.fullInitialization
is basically just an invertedkeymanweb.embedded
flag, but isn't nearly as explicit.util.wait
function is only ever declared for 'native' mode and basically serves as an embedded marker; the code has a lot ofif(typeof(util.wait) == 'function')
tests that equate toif(!keymanweb.embedded)
.util.wait
andutil.alert
in kmwembedded.js that does nothing.The text was updated successfully, but these errors were encountered: