Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveToNext Function Does Not Check For Existence of Next Input #63

Closed
Sethyboy0 opened this issue Apr 26, 2017 · 3 comments
Closed

moveToNext Function Does Not Check For Existence of Next Input #63

Sethyboy0 opened this issue Apr 26, 2017 · 3 comments
Milestone

Comments

@Sethyboy0
Copy link
Contributor

The moveToNext function in keymanweb.js never actually checks if the target it wants to focus on exists or not, causing errors when it doesn't. I've seen this come up in my implementation for my employer where moveToNext is called and no other inputs exist on the page.

@jahorton
Copy link
Contributor

jahorton commented May 11, 2017

Could you give some example code where this is the case? It would help us narrow down the cause of your exact issue.

Also, in the above-mentioned implementation for your employer, does the number of inputs change over the lifetime of your page? If so, I suspect that's highly related.

@Sethyboy0
Copy link
Contributor Author

Sethyboy0 commented May 11, 2017 via email

@jahorton jahorton mentioned this issue May 16, 2017
@mcdurdin mcdurdin modified the milestone: P1S1 May 25, 2017
@jahorton jahorton added the web/ label May 26, 2017
jahorton pushed a commit that referenced this issue Jun 1, 2017
…le/touch-based devices, though that may be hesitancy on their part to work well with dynamic elements.
jahorton pushed a commit that referenced this issue Jun 1, 2017
…re readded. ... yes, that could be a thing. Issue #63 complete!

Also moved testing files from temporary 'testing' directory to /web/samples.
@jahorton
Copy link
Contributor

jahorton commented Jun 5, 2017

Fixed with PR #80, as the issue was highly related to dynamic element removal.

@jahorton jahorton closed this as completed Jun 5, 2017
@mcdurdin mcdurdin added the bug label Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants