New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(developer): upgrade ngrok to v3 #10359
Conversation
User Test ResultsTest specification and instructions
Test Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@bharanidharanj can you re-test this? When you do, if it fails again, can you do the following steps:
@keymanapp-test-bot retest TEST_NGROK_WORKING |
@bharanidharanj can you try the following for me please and report on the results:
Thank you! |
@mcdurdin I am getting the following message after running the command lines, |
Okay, I am a little bit stumped. Not sure what is causing the problem, perhaps we will need to do a remote desktop session on Monday? |
@mcdurdin Okay, Thanks. |
@bharanidharanj I have put in a fix to remove the region parameter. Can you retest once the build completes? Thank you! @keymanapp-test-bot retest |
@mcdurdin Sure. I will do it. |
TODO: remove the region parameter entirely now that we have verified that this works, and port this to 16.0x |
Changes in this pull request will be available for download in Keyman version 17.0.251-alpha |
Fixes #10357.
User Testing
TEST_NGROK_UPGRADE: In Keyman Developer, Tools|Options|Server, Configure Server, click
Download or update ngrok
. Once the download completes, the label to the right of the button should show "ngrok version 3.5.0" or similar (it must be version 3.2 or later to pass).TEST_NGROK_WORKING: In Keyman Developer, verify that you have enabled ngrok in Keyman Developer Server Options. Open a keyboard, and test it on web. Verify that a URL appears in the list of server web addresses, and that when you select it to Open in browser, the test web site works correctly.
Note: your ngrok entry will look different to this but will be a public website: